[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnulib-tool.py: Store the module name instead of computing i
From: |
Collin Funk |
Subject: |
Re: [PATCH] gnulib-tool.py: Store the module name instead of computing it. |
Date: |
Tue, 26 Mar 2024 16:46:49 -0700 |
User-agent: |
Mozilla Thunderbird |
Hi Bruno,
On 3/26/24 3:19 PM, Bruno Haible wrote:
> Feel free to do so. Either in GLFileSystem only, or globally - as you like.
I would prefer to do it globally. I find they make it easier to
reference code. Since we have *some* of the information in docstrings,
I would just remove those and turn them into actual type hints.
Since the type-hinting requires the
from __future__ import annotations
wizardry for older versions of Python3, it would be nice for me to be
able to confirm things remain compatible.
Since we don't use (and probably won't ever have the need) for third
party packages, what do you think of this patch adding the PYTHON
environment variable?
Most GNU/Linux distributions and FreeBSD package various python3.x
packages. This would allow me to run the test case:
$ env PYTHON=python3.7 GNULIB_TOOL_IMPL=py ./test-all.sh
This should be enough to ensure type hints + no future changes break
compatibility with older Python versions. And doesn't require learning
the complicated virtual environment stuff.
Collin
0001-gnulib-tool.py-Obey-the-PYTHON-environment-variable.patch
Description: Text Data
- [PATCH] gnulib-tool.py: Fix sorting of modules when --local-dir is used., Collin Funk, 2024/03/26
- [PATCH] gnulib-tool.py: Store the module name instead of computing it., Collin Funk, 2024/03/26
- Re: [PATCH] gnulib-tool.py: Store the module name instead of computing it., Bruno Haible, 2024/03/26
- Re: [PATCH] gnulib-tool.py: Store the module name instead of computing it., Collin Funk, 2024/03/26
- Re: [PATCH] gnulib-tool.py: Store the module name instead of computing it., Bruno Haible, 2024/03/26
- Re: [PATCH] gnulib-tool.py: Store the module name instead of computing it.,
Collin Funk <=
- Re: [PATCH] gnulib-tool.py: Store the module name instead of computing it., Bruno Haible, 2024/03/26
- Re: [PATCH] gnulib-tool.py: Store the module name instead of computing it., Collin Funk, 2024/03/26
- Re: [PATCH] gnulib-tool.py: Store the module name instead of computing it., Bruno Haible, 2024/03/26
- Re: [PATCH] gnulib-tool.py: Store the module name instead of computing it., Collin Funk, 2024/03/31
- Re: [PATCH] gnulib-tool.py: Store the module name instead of computing it., Bruno Haible, 2024/03/31
- Re: [PATCH] gnulib-tool.py: Store the module name instead of computing it., Collin Funk, 2024/03/31