Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 53, 54.

[Bruno Haible]

Hi Collin,

Re 0003 (part 53):
In the function _eliminate_NMD, the list accumulation expressions are a bit
complex. Here, I feel, a better indentation is not even enough. Can you refactor
this as follows:
  - A function _eliminate_NMD_from_line that takes a single line as argument
    and return a line or None.
  - A function _eliminate_NMD that invokes _eliminate_NMD_from_line on each
    line of the snippet, and combines the results?

Also, please don't drop comments that are present in the original code, such as:

  # Replace NMD, so as to remove redundant "$(MKDIR_P) '.'" invocations.
  # The logic is similar to how we define gl_source_base_prefix.

Recall that ultimately we want to drop the gnulib-tool shell implementation.


The only patch that I've applied from you so far, today, is 0005.
0001, 0002, 0003, 0004 all need to be revisited.

Bruno