[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gnulib-tool.py: Follow gnulib-tool changes, part 43, 44.
From: |
Collin Funk |
Subject: |
Re: gnulib-tool.py: Follow gnulib-tool changes, part 43, 44. |
Date: |
Wed, 6 Mar 2024 02:53:54 -0800 |
User-agent: |
Mozilla Thunderbird |
On 3/6/24 12:26 AM, Collin Funk wrote:
> gnulib-tool.py --create-testdir --dir test-python readme-release
> gnulib-tool --create-testdir --dir test-shell readme-release
> git diff --no-index test-python/gltests/Makefile.am
> test-shell/gltests/Makefile.am
While running that I noticed this in gltests/Makefile.am:
-LDADD = ../gllib/libgnu.a libtests.a ../gllib/libgnu.a
+LDADD = ../gllib/libgnu.a
I've copied the logic for this from gnulib-tool and the attached patch
fixes this.
Also I've just noticed that GLImport has an exit() call that prevents
the advice for headers and such from being printed [1]. It is also
documented in gnulib-tool.py.TODO [2]. Is there a reason for this? The
git history doesn't seem to say much and it worked fine when I tried
it _once_. Just seems sort of strange LOL
[1] https://git.savannah.gnu.org/cgit/gnulib.git/tree/pygnulib/GLImport.py#n1337
[2] https://git.savannah.gnu.org/cgit/gnulib.git/tree/gnulib-tool.py.TODO#n29
Collin
0005-gnulib-tool.py-Fix-value-of-LDADD-for-libtests.patch
Description: Text Data
- gnulib-tool.py: Follow gnulib-tool changes, part 42., Collin Funk, 2024/03/05
- gnulib-tool.py: Follow gnulib-tool changes, part 43, 44., Collin Funk, 2024/03/06
- Re: gnulib-tool.py: Follow gnulib-tool changes, part 43, 44.,
Collin Funk <=
- Re: gnulib-tool.py: Follow gnulib-tool changes, part 43, 44., Bruno Haible, 2024/03/06
- Re: gnulib-tool.py: Follow gnulib-tool changes, part 42., Bruno Haible, 2024/03/06