bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gnulib-tool.py: Follow gnulib-tool changes, part 28.


From: Bruno Haible
Subject: Re: gnulib-tool.py: Follow gnulib-tool changes, part 28.
Date: Sun, 25 Feb 2024 00:42:59 +0100

Hi Collin,

> The first one fixes an item in the
> gnulib-tool.py.TODO file. Previously the "Generated by gnulib-tool"
> comment at the top of the Makefile would be on one line.

Thanks! Applied.

Only one question on this one:

> +        if len(avoids) > 0:
> +            actioncmd += ''.join([f" \\\n#  --avoid={x}" for x in 
> sorted(avoids)])
> +        if len(modules) > 0:
> +            actioncmd += ''.join([f" \\\n#  {x}" for x in sorted(modules)])

The sorted(...) instruction is not present in gnulib-tool lines 5647..5652.
Why is it needed? Can you make a quick test with a gnulib-tool invocation
that has several --avoid=... arguments and several module arguments that
are not in increasing alphabetical order?

Bruno






reply via email to

[Prev in Thread] Current Thread [Next in Thread]