[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] nstrftime: allow opt-out of AM/PM adjustment
From: |
Bruno Haible |
Subject: |
Re: [PATCH] nstrftime: allow opt-out of AM/PM adjustment |
Date: |
Thu, 15 Feb 2024 22:56:33 +0100 |
Paul Eggert wrote:
> For Emacs I would rather avoid bringing in the Gnulib locking code,
> since Emacs has its own idea about locks and its main engine is
> single-threaded anyway.
> Provide a way to use the nstrftime module while avoiding its
> recently-added localename dependency, which entails locking code.
With this remark, you incited me to optimize 'localename' w.r.t.
locking — regarding the runtime execution of locking primitives,
as well as regarding the module dependencies.
In the current state, your patch no longer trims away the locking
dependencies of 'nstrftime' — since nstrftime does not have such
locking dependencies any more.
The effect of your patch is merely that Emacs users on Solaris or NetBSD,
in a French locale (or one of many other locales) will get an AM/PM
string attached to their date+time display. Something which is a no-go
in such locales, because it goes against the cultural conventions.
I therefore suggest that you revert the change to strftime.c.
You can also remove the '--avoid=localename' option from emacs'
gnulib-tool options: it is now a no-op, since 'nstrftime' no longer
depends on 'localename'.
Bruno