[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Possible bug in qcopy-acl.c
From: |
Ondrej Valousek |
Subject: |
Possible bug in qcopy-acl.c |
Date: |
Fri, 1 Sep 2023 11:24:59 +0000 |
Hi all,
I think we might have a bug in qcopy-acl.c as currently, when we copy files
from say NFSv4 to ext4 filesystems, then "cp -p" produces warning that it could
not preserve permissions.
That makes a sense, but perhaps we should issue "attr_copy_file()" only if the
file has a non-trivial acls on it (can be checked with our function
file-has-acl()).
The benefit of that would be that copying files from NFS to non-nfs filesystems
would only produce this warning if there is a non-trivial acl present.
The disadvantage of it would be the additional call for file-has-acl() so hence
few more kernel calls.
What do you think?
Ondrej
- Possible bug in qcopy-acl.c,
Ondrej Valousek <=