bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] boot-time,readutmp: do not depend on fopen-gnu


From: Paul Eggert
Subject: [PATCH] boot-time,readutmp: do not depend on fopen-gnu
Date: Sat, 12 Aug 2023 16:06:08 -0700

These modules should work well enough even if fopen is not fixed
to conform to fopen-gnu standards.  The only gotcha I can see is
older fopen implementations that lack support for "e", and
a potential O_CLOEXEC leak is not worth worrying about.
* modules/boot-time (Depends-on):
* modules/readutmp (Depends-on):
Remove fopen-gnu.
---
 ChangeLog         | 9 +++++++++
 modules/boot-time | 1 -
 modules/readutmp  | 1 -
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index c1a8c8e37c..407e1733ca 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,14 @@
 2023-08-12  Paul Eggert  <eggert@cs.ucla.edu>
 
+       boot-time,readutmp: do not depend on fopen-gnu
+       These modules should work well enough even if fopen is not fixed
+       to conform to fopen-gnu standards.  The only gotcha I can see is
+       older fopen implementations that lack support for "e", and
+       a potential O_CLOEXEC leak is not worth worrying about.
+       * modules/boot-time (Depends-on):
+       * modules/readutmp (Depends-on):
+       Remove fopen-gnu.
+
        readutmp: do not depend on timespec_get
        boot-time code no longer needs it.
        * modules/readutmp (Depends-on): Remove timespec_get.
diff --git a/modules/boot-time b/modules/boot-time
index 749b9014cd..d8ab075024 100644
--- a/modules/boot-time
+++ b/modules/boot-time
@@ -11,7 +11,6 @@ m4/readutmp.m4
 Depends-on:
 c-strtod
 extensions
-fopen-gnu
 idx
 stat-time
 stdbool
diff --git a/modules/readutmp b/modules/readutmp
index e314841298..304cebca0c 100644
--- a/modules/readutmp
+++ b/modules/readutmp
@@ -11,7 +11,6 @@ m4/systemd.m4
 Depends-on:
 c-strtod
 extensions
-fopen-gnu
 idx
 stat-time
 stdbool
-- 
2.39.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]