[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Use the 'extern-inline' module explicitly where needed
From: |
Bruno Haible |
Subject: |
Use the 'extern-inline' module explicitly where needed |
Date: |
Mon, 03 Apr 2023 20:22:46 +0200 |
When a .h file uses _GL_INLINE_HEADER_BEGIN / _GL_INLINE_HEADER_END,
it needs a dependency towards the 'extern-inline' module.
Some modules had this dependency only accidentally; it's better to
have it explicitly, for maintenance.
I found the list of affected modules through
$ for m in $(for f in `fgrep -l _GL_INLINE_HEADER_BEGIN lib/*.h | sort`; do
./gnulib-tool --find $f; done); do
if grep '^extern-inline' modules/$m > /dev/null; then :; else echo $m; fi;
done
2023-04-03 Bruno Haible <bruno@clisp.org>
Use the 'extern-inline' module explicitly where needed.
* modules/fdutimensat (Depends-on): Add extern-inline.
* modules/file-has-acl (Depends-on): Likewise.
* modules/hamt (Depends-on): Likewise.
* modules/relocatable-prog-wrapper (Depends-on): Likewise.
* modules/safe-alloc (Depends-on): Likewise.
* modules/string-desc (Depends-on): Likewise.
* modules/string-desc-quotearg (Depends-on): Likewise.
* modules/xstring-desc (Depends-on): Likewise.
* modules/xvasprintf (Depends-on): Likewise.
diff --git a/modules/fdutimensat b/modules/fdutimensat
index 21d656f1a5..e2cf553466 100644
--- a/modules/fdutimensat
+++ b/modules/fdutimensat
@@ -6,6 +6,7 @@ lib/fdutimensat.c
lib/utimens.h
Depends-on:
+extern-inline
futimens
utimensat
diff --git a/modules/file-has-acl b/modules/file-has-acl
index fa2ea4ca22..be1048dfe1 100644
--- a/modules/file-has-acl
+++ b/modules/file-has-acl
@@ -8,6 +8,7 @@ m4/acl.m4
Depends-on:
acl-permissions
+extern-inline
free-posix
stat
stdbool
diff --git a/modules/hamt b/modules/hamt
index d73f09c2db..d8b0d7207a 100644
--- a/modules/hamt
+++ b/modules/hamt
@@ -7,6 +7,7 @@ lib/hamt.c
Depends-on:
count-one-bits
+extern-inline
flexmember
inttypes-incomplete
stdbool
diff --git a/modules/relocatable-prog-wrapper b/modules/relocatable-prog-wrapper
index c885ce2759..e1a14d0448 100644
--- a/modules/relocatable-prog-wrapper
+++ b/modules/relocatable-prog-wrapper
@@ -57,6 +57,7 @@ double-slash-root
eloop-threshold
environ
errno
+extern-inline
fcntl-h
filename
idx
diff --git a/modules/safe-alloc b/modules/safe-alloc
index 180aa8a2de..370b30f625 100644
--- a/modules/safe-alloc
+++ b/modules/safe-alloc
@@ -8,6 +8,7 @@ m4/safe-alloc.m4
Depends-on:
calloc-gnu
+extern-inline
reallocarray
configure.ac:
diff --git a/modules/string-desc b/modules/string-desc
index 044ee266e4..047e2d390c 100644
--- a/modules/string-desc
+++ b/modules/string-desc
@@ -10,6 +10,7 @@ Depends-on:
stdbool
idx
ialloc
+extern-inline
memchr
memrchr
memmem
diff --git a/modules/string-desc-quotearg b/modules/string-desc-quotearg
index 42472b0774..17e0fa5abf 100644
--- a/modules/string-desc-quotearg
+++ b/modules/string-desc-quotearg
@@ -8,6 +8,7 @@ lib/string-desc-quotearg.c
Depends-on:
string-desc
quotearg
+extern-inline
configure.ac:
diff --git a/modules/xstring-desc b/modules/xstring-desc
index d0cda2d23e..5653853686 100644
--- a/modules/xstring-desc
+++ b/modules/xstring-desc
@@ -8,6 +8,7 @@ lib/xstring-desc.c
Depends-on:
string-desc
xalloc-die
+extern-inline
configure.ac:
diff --git a/modules/xvasprintf b/modules/xvasprintf
index 4ebbba470a..b322890876 100644
--- a/modules/xvasprintf
+++ b/modules/xvasprintf
@@ -13,6 +13,7 @@ stdio
vasprintf
xalloc
xalloc-die
+extern-inline
xsize
stdarg
errno
- Use the 'extern-inline' module explicitly where needed,
Bruno Haible <=