Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

[Reuben Thomas]

On Tue, 7 Feb 2023 at 15:22, Corinna Vinschen <vinschen@redhat.com> wrote:

In Cygwin projects using libtool, we always have to add -no-undefined
iLDFLAGS.  This is some old safe-guard in libtool to remind developers
that when creating Windows DLLs, all external symbols must be resolved.

Fortunately, libtool allows this flags also on other platforms which
don't require its usage.

Patch is attached.  It would be nice if that's ok for inclusion.

I did apply this patch, but just noticed that it broke the Mingwin build; see:

https://github.com/rrthomas/recode/actions/runs/4115515520/jobs/7104330023

I haven't had time to look into it yet; help welcome!

 

--

https://rrt.sc3d.org