[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements
From: |
Eli Zaretskii |
Subject: |
bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body |
Date: |
Sat, 27 Apr 2024 18:41:59 +0300 |
> From: john muhl <jm@pub.pink>
> Cc: Jacob Leeming <jacobtophatleeming@gmail.com>, dmitry@gutov.dev,
> 70345@debbugs.gnu.org, theo@thornhill.no
> Date: Sat, 27 Apr 2024 08:10:47 -0500
>
> The test should check that the c-sharp grammar is available so
> that it gets marked as skipped instead of failed.
>
> >From 068cad8612c31cea41f0cc21a865efe0785d4e7a Mon Sep 17 00:00:00 2001
> From: john muhl <jm@pub.pink>
> Date: Sat, 27 Apr 2024 09:55:42 -0500
> Subject: [PATCH] ; Skip 'csharp-ts-mode' test if grammar is missing
>
> * test/lisp/progmodes/csharp-mode-tests.el
> (csharp-ts-mode-test-indentation): Skip test instead of failing.
> ---
> test/lisp/progmodes/csharp-mode-tests.el | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/test/lisp/progmodes/csharp-mode-tests.el
> b/test/lisp/progmodes/csharp-mode-tests.el
> index 2878fa601f2..b3c57a7026b 100644
> --- a/test/lisp/progmodes/csharp-mode-tests.el
> +++ b/test/lisp/progmodes/csharp-mode-tests.el
> @@ -27,6 +27,7 @@ csharp-mode-test-indentation
> (ert-test-erts-file (ert-resource-file "indent.erts")))
>
> (ert-deftest csharp-ts-mode-test-indentation ()
> + (skip-unless (treesit-ready-p 'c-sharp))
> (ert-test-erts-file (ert-resource-file "indent-ts.erts")))
Thanks, but shouldn't we invoke treesit-ready-p with second argument
non-nil?
- bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body, (continued)
- bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body, Yuan Fu, 2024/04/14
- bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body, Theodor Thornhill, 2024/04/15
- bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body, Jacob Leeming, 2024/04/15
- bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body, Jacob Leeming, 2024/04/22
- bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body, john muhl, 2024/04/27
- bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body,
Eli Zaretskii <=
- bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body, john muhl, 2024/04/27
- bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body, Eli Zaretskii, 2024/04/27