| From what I can tell Alastair is using conf-mode, not toml-ts-mode.
Alastait: toml-ts-mode is a new builtin tree-sitter based major-mode for working with TOML files.
If you have issues with conf-mode and certain TOML files, you could try that instead. I just tried it with your test-files and I don't see any incorrect fontification, so it seems to work fairly well.
Eli: If there's a bug to fix in conf-mode, I'm going to assume it would be better to CC the conf-mode maintainer than the toml-ts-mode maintainer. It might gain more traction.
—
Kind Regards
Jostein Kjønigsen
On 14 Apr 2024, at 21:59, Alastair Irving <alastair.j.irving@gmail.com> wrote:
On 14/04/2024 17:46, Eli Zaretskii wrote:Date: Sun, 14 Apr 2024 11:25:08 +0100
From: Alastair Irving <alastair.j.irving@gmail.com>
When editting TOML files with conf-mode[toml] the face property is being
set badly on certain characters. This occurs in Emacs 29.3 (running
with -q) but has been present in older versions. Steps to reproduce:
1. Create a file test.toml containing the following:
[package]
name = "test"
# See more keys and their definitions at
https://doc.rust-lang.org/cargo/reference/manifest.html
[dependencies]
2. Navigate to the d in dependencies and evaluate
(text-properties-at (point))
The output for me looks like
(face (font-lock-type-face font-lock-type-face font-lock-type-face
font-lock-type-face font-lock-type-face font-lock-ty\
pe-face font-lock-type-face font-lock-type-face font-lock-type-face
font-lock-type-face
It looks like something is wrong in the font-lock setup and the same
face is being applied very many times.
I cannot reproduce this here, neither in Emacs 29 nor in Emacs 30.
What version of the TOML grammar library are you using?
I don't think it's using a TOML grammar library, just conf-mode bundled with EMACS "The major mode is Conf[TOML] mode defined in conf-mode.el". I think an extra newline was inserted in the TOML I pasted (in the comment before the URL), it should be 4 lines total. I've attached the exact file.
Jostein and Yuan, can you please look into this?
<test.toml>
|