bug#48356: 28.0.50; choose-completion discards the suffix after the completion boundary

[Dmitry Gutov]

Hi Stefan,

On 09/04/2024 02:50, Stefan Monnier wrote:
> > ...which translates to "/" because of the double slash -- the filesystem
> >   root directory (*). But that's the same data which would be used by any
> >   other proposed solution, too.
>
> More or less, tho the "ideal" solution is to do that in the
> completion-style code, which has a bit more knowledge about it.

Doing it in completion-style, though, would either require a relatively 
awkward change in most/all styles (e.g. the "new dynamic variable" 
route), or a more straightforward change in styles together with an 
incompatible change in completion-all-completions.

So on balance, would you say it's a good idea to a) use this approach in 
minibuffer-completion-help, b) create a named function for it, for other 
callers to take advantage of it as well?

IIUC Vertico (and other minibuffer completion UIs) might be interested.

> >   So maybe it should be either be fixed in the
> >   completion table (avoid adding trailing slash when the last boundary is
> >   already followed by slash?), or the insertion code should do some
> >   additional post-processing of the completion string.
>
> I think you can fix it in the same ad-hoc way we use elsewhere: compare
> the first char after the boundary with the last char of the completion
> and drop one of the two if they're the same.

Looks like completion--merge-suffix is the helper to use.

> > +             (base-suffix (let ((suffix (buffer-substring (point) end)))
> > +                            (substring
> > +                             suffix
> > +                             (cdr (completion-boundaries string
> > +                                                         
> > minibuffer-completion-table
> > +                                                         
> > minibuffer-completion-predicate
> > +                                                         suffix)))))
>
> I think you want to be careful to pass (buffer-substring start (point))
> rather than `string` to `completion-boundaries`.

Thanks, see the update attached.

> In theory this approach can "do the wrong thing" with some completion
> styles, but AFAIK they haven't been written yet.  🙂

So you figure that such theoretical style would return adjusted 
base-suffix in -all-completions method, not just in -try-completion?

base-suffix-v2.diff
Description: Text Data