[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#70138: Do not intercept C-TAB on Haiku OS
From: |
Tor-björn Claesson |
Subject: |
bug#70138: Do not intercept C-TAB on Haiku OS |
Date: |
Wed, 03 Apr 2024 18:25:44 +0300 |
User-agent: |
mu4e 1.8.13; emacs 29.2 |
Hi!
Thanks, well spotted!
Here is a new version of the patch.
0001-New-variable-haiku-pass-control-tab-to-system-rev2.patch
Description: Text Data
Thank you very much for helping me fix this=)
Cheers,
Tor-björn
Po Lu <luangruo@yahoo.com> writes:
> Tor-björn Claesson <tclaesson@gmail.com> writes:
>
>> Hi!
>>
>> Thanks for the feedback!
>>
>> I have updated the patch and commit message, and am happy to fix it
>> further if needed.
>
> Thanks. Three minor (or perhaps trifling) issues:
>
>> Allow passing C-TAB on to the Haiku operating system, fixing window
>> switching when an Emacs frame has focus (Bug#70138).
> --
>
> Duplicate whitespace.
>
>> * src/haiku_support.cc (DispatchMessage): conditionally pass message to
>> BWindow.
>> * src/haiku_support.h:
>> * src/haikufns.c (haiku_should_pass_control_tab_to_system):
>> Add variable haiku-pass-control-tab-to-system, and c function
>> haiku_should_pass_control_tab_to_system.
>
> C should be capitalized, as should the first word in each sentence.
> Please also fill the message to 64 columns; in a vc-log buffer, simply
> typing M-q should suffice.
>
>> + DEFVAR_BOOL("haiku-pass-control-tab-to-system",
>> + haiku_pass_control_tab_to_system,
>> + doc: /*Whether or not to pass C-TAB to the system.
> -
>> +Setting this variable will cause Emacs to pass C-TAB to the system
>> +(allowing window switching on the Haiku operating system), rather than
>> +intercepting it.*/);
> -
>
> Missing whitespace. Otherwise, you're good to go.
--
Mvh,
Tor-björn Claesson