bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#69714: [PATCH] Improve ert-font-lock assertion parser


From: Vladimir Kazanov
Subject: bug#69714: [PATCH] Improve ert-font-lock assertion parser
Date: Sun, 31 Mar 2024 17:56:38 +0000

Hi Mattias,

Thanks for noticing this!

> If you want the regexp to match a list of one or more symbols, what about 
> this:
>
>   (rx "("
>       (* whitespace)
>       (regexp ert-font-lock--face-symbol-re)
>       (* (+ whitespace)
>          (regexp ert-font-lock--face-symbol-re))
>       ")")
>

Got it, thanks. I forgot about relint! Regex performance is easy to
get wrong. I'd really like peg.el to be merged and used for this kind
of parsing.

Anyway, can you please take a look at the patch? It fixes the problem
noticed by relint as well as a couple of other minor things, and adds
tests to make sure regexes work the way I want them to.

Thank you
Vlad


-- 
Regards,

Vladimir Kazanov

Attachment: v1-0001-Fix-symbol-list-matching-regexps.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]