[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#70093: Remove unnecessary `image-tests--map-equal'
From: |
Joseph Turner |
Subject: |
bug#70093: Remove unnecessary `image-tests--map-equal' |
Date: |
Sat, 30 Mar 2024 22:32:26 -0700 |
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: Eli Zaretskii <eliz@gnu.org>, David Ponce <da_vid@orange.fr>
>> From: Joseph Turner <joseph@breatheoutbreathe.in>
>> Date: Sat, 30 Mar 2024 12:44:14 -0700
>>
>> With the resolution of bug#69992, it may be possible to remove the
>> `image-tests--map-equal' equality predicate from lisp/image-tests.el.
>
> Why is it a good idea to remove tests? If the test tests some of our
> code which should work as the test assumes, we should not remove it.
Not removing tests, but rather making the tests more strict (if possible).
>> Eli and David, would you please apply the attached patch and then run
>> the tests to see if we still need to allow for tolerances in
>> `image--compute-map-and-original-map'?
>
> ENOPATCH
Sorry about that. Please check if the tests still pass on your machine
when we use `equal' to compare image maps.
0001-Compare-image-maps-with-equal-in-tests.patch
Description: Text Data