bug#69666: [PATCH] (vtable-update-object): Make old-object argument optional

[Adam Porter]

Hi Eli,

Thanks, please see the attached patch.

On 3/16/24 05:29, Eli Zaretskii wrote:

> Thanks, this LGTM.  Just a couple of minor nits:
>
> > Subject: [PATCH] (vtable-update-object): Make old-object argument
> > optional (Bug#69666)
>
> This is too long for the generated ChangeLog.  Since this just 
> reiterates what the log message below it says, I suggest:
>
> . make the heading more terse, like
>
> 'vtable-update-object' can now be called with one argument
>
> . move the bug number to the actual log entry:
>
> * lisp/emacs-lisp/vtable.el (vtable-update-object): Make
> 'old-object' argument optional.  (Bug#69666)

Done.

For future reference, is there a way to know whether the heading line is
too long for the ChangeLog entry, other than manually counting?

> "When" has a meaning of time, which is not what you mean here.  I 
> suggest to use "If" in these cases.

Done.

Also, please note that I just discovered another limitation of this
function, which I've filed as bug#69837.  Since it seems quite
important, I've also updated the patch to mention the limitation in the
docstring and manual.

Thanks,
Adam

0001-vtable-update-object-can-now-be-called-with-one-argu.patch
Description: Text Data