bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#67032: 30.0.50; ERC 5.6-git: Treat erc-send-message more responsibly


From: J.P.
Subject: bug#67032: 30.0.50; ERC 5.6-git: Treat erc-send-message more responsibly
Date: Wed, 13 Mar 2024 19:11:30 -0700
User-agent: Gnus/5.13 (Gnus v5.13)

> This has been installed as
>
>   1d2aa130cae * Revive erc-command-indicator as new module

One aspect this change should've addressed but didn't was using the
revived `command-indicator' facility in `erc-load-irc-script-lines' to
make its output more predictable and consistent with other displayed
messages. While leaving it to rot would of course be safer, I suspect
it's rarely used enough to warrant the risk. An ancillary benefit of
fixing this is that it helps clarify the role of boolean return values
for `erc-process-input-line', `erc-send-input-line-function',
`erc-message', and the various `erc-cmd-FOO' slash-command handlers.
See second patch (lacks tests).

Thanks.

P.S. The commit named above unfortunately cites the wrong bug number
(67031) in its commit message.

Attachment: 0001-5.6-Restore-leading-space-to-right-margin-stamps-in-.patch
Description: Text Data

Attachment: 0002-5.x-Use-command-indicator-in-erc-load-irc-script-lin.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]