[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#69733: [PATCH] Flyspell (flyspell-word): do not force 'save-excursio
From: |
Eli Zaretskii |
Subject: |
bug#69733: [PATCH] Flyspell (flyspell-word): do not force 'save-excursion' on timers |
Date: |
Tue, 12 Mar 2024 15:20:10 +0200 |
> From: Daniel Pettersson <daniel@dpettersson.net>
> Date: Mon, 11 Mar 2024 15:37:55 +0100
>
> As I understand the manual there is nothing that states that one should
> assume that you cant move the point in buffer with timers. This is of
> course impossible to guarantee as any code can be calling
> accept-process-output. But it seams like an good idea to have code that
> is triggered by post-command-hook to not impose such conditions.
Thanks, but I don't think I understand the relation between what you
say above (and in the comments in your patch below) and the code
change you propose:
> (while (progn
> - (accept-process-output ispell-process)
> + ;; don't force save-excursion to timers.
> + ;; only accept output from ispell-process.
> + (accept-process-output ispell-process nil nil t)
Where's save-excursion and point moving to which you allude here?
More importantly, why is it a good idea to stop running timers during
this accept-process-output call and ignore output from other
subprocesses?
bug#69733: [PATCH] Flyspell (flyspell-word): do not force 'save-excursion' on timers, Dmitry Gutov, 2024/03/15