bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#68272: [PATCH] Fix -1 leaking from C to lisp in 'read-event' etc.


From: Tim Ruffing
Subject: bug#68272: [PATCH] Fix -1 leaking from C to lisp in 'read-event' etc.
Date: Sat, 09 Mar 2024 13:33:53 +0100

Third revision.

 - Addressed Stefan's nit.
 - Extended the large comment.
 - Switched to Stefan's suggestion for calc.
 - Added a NEWS item that describes the suggestion
 - Added a commit that removes the Microsoft hack

> > It might be worth mentioning that the main difference is the
> > availability of `executing-kbd-macro` to let ELisp code behave
> > differently when called via a kmacro than via "live input".
> > Which also kind of justifies why `read-key-sequence` wants to
> > detect the end: if a kmacro ends in the middle of a key sequence,
> > then
> > it's triggered both my kmacro and by live input.
> > [ Of course, we could handle it in the command loop instead:
> >   check and compare the set of pending kmacro events before and
> > after
> > we
> >   call `read-key-sequence`.  ]

I didn't do this, because I couldn't follow exactly what you're saying.
Feel free to suggest a sentence.

Best,
Tim

Attachment: 0001-Extract-check-for-end-of-macro-to-function.patch
Description: Text Data

Attachment: 0002-src-keyboard.c-requeued_events_pending_p-Improve-nam.patch
Description: Text Data

Attachment: 0003-src-keyboard.c-requeued_events_pending_p-New-functio.patch
Description: Text Data

Attachment: 0004-Continue-reading-in-read-event-etc.-at-the-end-of-a-.patch
Description: Text Data

Attachment: 0005-Remove-workarounds-for-solved-read-event-bug.patch
Description: Text Data

Attachment: 0006-lisp-calc-calc-prog.el-Switch-to-new-method-of-detec.patch
Description: Text Data

Attachment: 0007-src-keyboard.c-read_key_sequence-Remove-MSVC-compati.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]