[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#68801: 30.0.50; minibuffer-visible-completions=t makes RET in comple
From: |
Juri Linkov |
Subject: |
bug#68801: 30.0.50; minibuffer-visible-completions=t makes RET in completion-in-region a no-op with nothing selected |
Date: |
Thu, 29 Feb 2024 19:56:31 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) |
> Spencer Baugh <sbaugh@janestreet.com> writes:
>> I'm thinking the right thing to do is just to go with my original patch
>> which only binds RET when there's a selected completion. That's simple
>> and straightforward.
>>
>> But I'm not sure how to adapt my completion-show-help change for that: I
>> want to hint to the user that they should hit RET, but RET is only bound
>> when a completion is selected, which isn't the case when *Completions*
>> is first displayed. Any ideas? Could we just hardcode "RET" in the
>> help text?
>
> The solution is obvious in retrospect, just add a defvar to force the
> bindings on.
>
> Complete patch attached, I think this closes the bug.
Good idea, thanks. I will test your patch for a while.