[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#69405: [PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests
From: |
Eli Zaretskii |
Subject: |
bug#69405: [PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests |
Date: |
Mon, 26 Feb 2024 18:52:41 +0200 |
> From: Mattias Engdegård <mattias.engdegard@gmail.com>
> Date: Mon, 26 Feb 2024 17:26:43 +0100
> Cc: 69405@debbugs.gnu.org,
> casouri@gmail.com
>
> 26 feb. 2024 kl. 14.59 skrev Eli Zaretskii <eliz@gnu.org>:
>
> > Can't we do that in the test harness, instead of introducing
> > test-suite dependencies into the built Emacs binary? For example, how
> > about adding to tree-sitter-extra-load-path in treesit-tests.el
> > instead?
>
> Yes, that's probably a better idea. We don't even need anything in the test
> suites if we set `treesit-extra-load-path` in the Makefile, as in this patch.
Right, thanks. This is much better.
> (We could set an environment variable instead, but then it would need
> decoding in each tree-sitter test as well, and the change to the Makefile
> wouldn't really be simpler.)
The question is how important is it to support cases where the
directory is not under ~/.emacs.d/tree-sitter/, but somewhere else,
perhaps created specifically for running the tests without affecting
the production sessions? If that's not very important, then
supporting just the HOME case should be enough.