[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#69237: 30.0.50; Toggle password visibility
From: |
Eli Zaretskii |
Subject: |
bug#69237: 30.0.50; Toggle password visibility |
Date: |
Sun, 25 Feb 2024 16:09:13 +0200 |
> Cc: 69237-done@debbugs.gnu.org
> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
> Date: Sun, 25 Feb 2024 13:34:26 +0000
>
> Michael Albinus <michael.albinus@gmx.de> writes:
>
> >> * Should we keep the double hyphen in "read-passwd--toggle-visibility"?
> >> Feeling like it connotes "Emacs internals" somewhat, and wondering if
> >> it's appropriate for interactive commands since they are "user-facing",
> >> and users might feel discouraged from remapping "internal-looking"
> >> commands.
> >
> > It is not intended that users call 'M-x read-passwd--toggle-visibility'.
> > It makes sense only when you are already editing the minibuffer, typing
> > the password.
>
> Right, I don't expect many users to run this command via M-x. My
> thinking went more toward users who might want to do…
>
> (keymap-unset read-passwd-map "\t" 'remove)
> (keymap-set read-passwd-map "C-c \t" 'read-passwd--toggle-visibility)
>
> … and who might feel uneasy about that "--" in their personal config.
IMO, commands should never have two dashes in their names, because
commands are never "internal", by their very definition.
- bug#69237: 30.0.50; Toggle password visibility, (continued)
bug#69237: 30.0.50; Toggle password visibility, Kévin Le Gouguec, 2024/02/22
- bug#69237: 30.0.50; Toggle password visibility, Michael Albinus, 2024/02/23
- bug#69237: 30.0.50; Toggle password visibility, Kévin Le Gouguec, 2024/02/23
- bug#69237: 30.0.50; Toggle password visibility, Michael Albinus, 2024/02/25
- bug#69237: 30.0.50; Toggle password visibility, Kévin Le Gouguec, 2024/02/25
- bug#69237: 30.0.50; Toggle password visibility, Michael Albinus, 2024/02/25
- bug#69237: 30.0.50; Toggle password visibility, Kévin Le Gouguec, 2024/02/25
- bug#69237: 30.0.50; Toggle password visibility,
Eli Zaretskii <=
- bug#69237: 30.0.50; Toggle password visibility, Michael Albinus, 2024/02/25
- bug#69237: 30.0.50; Toggle password visibility, Eli Zaretskii, 2024/02/25
bug#69237: 30.0.50; Toggle password visibility, Michael Albinus, 2024/02/25
bug#69237: 30.0.50; Toggle password visibility, Kévin Le Gouguec, 2024/02/25