[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cm
From: |
Emanuel Berg |
Subject: |
bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt |
Date: |
Sat, 17 Feb 2024 09:52:43 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Tags: patch
J.P. wrote:
>> (erc-cmd-GMSG, erc-cmd-AME, erc-cmd-GME): new IRC slash commands
> ^ ^
> [...]
>> * lisp/erc/erc.el (erc-cmd-GME): should be #'erc--connected-and-joined-p,
>> not (erc--connected-and-joined-p)
>> (Bug#68401)
>
> This last item appears to describe an incremental patch revision only
> known to this discussion thread on the tracker [...]
>
> FWIW, other Emacs commit messages don't seem to have these
> interspersed sub-headers [...]
>
> Try to start each NEWS entry with a sentence [...]
>
>> +Also, the new IRC slash commands `erc-cmd-GMSG',
>> +`erc-cmd-AME', and `erc-cmd-GME' were added and are available
> ^~~~~~~~~~~~^
>
> For etc/*NEWS, I believe they prefer single 'quotes' [...]
>
>> -stalled and restart it. The default is after 120 seconds.
>> +stalled and restart it. The default is after 120 seconds.
> ~~~
>
> Please collapse the expanded TAB into a single space [...]
>> -paragraph-separate: "[ ]*$"
>> +paragraph-separate: "[ ]*$"
> ^
> I believe the TAB here is intentional, so please undo
> this hunk.
I sent a reply to this but it hasn't appeared yet, it seems.
Anyway, I finally understood all of what you asked for,
I think, so you can disregard that post and instead have
a look at the below patch, hopefully it covers it.
0368-Make-erc-cmd-AMSG-session-local-add-GMSG-AME-and-GME.patch
Description: Text Data
--
underground experts united
https://dataswamp.org/~incal
- bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt, Emanuel Berg, 2024/02/04
- Message not available
- bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt, Emanuel Berg, 2024/02/10
- bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt, Emanuel Berg, 2024/02/10
- bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt, Emanuel Berg, 2024/02/10
- bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt, J.P., 2024/02/13
- Message not available
- bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt, Emanuel Berg, 2024/02/18
- Message not available
- bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt,
Emanuel Berg <=
- bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt, J.P., 2024/02/20
- bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt, Emanuel Berg, 2024/02/20
- bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt, J.P., 2024/02/29