[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#68929: [PATCH] Copy which-key from GNU ELPA into core
From: |
Jeremy Bryant |
Subject: |
bug#68929: [PATCH] Copy which-key from GNU ELPA into core |
Date: |
Sat, 17 Feb 2024 13:10:51 +0000 |
0003-v2-Add-manual-entries-for-which-key.patch
Description: Text Data
Eli Zaretskii <eliz@gnu.org> writes:
> LGTM, thanks. Some minor comments below.
Revised patch attached.
>> * doc/emacs/display.texi (Display Custom): brief mention
>> * doc/emacs/help.texi (Key Help): reference node above
>
> The descriptions of the changes in these entries should be complete
> sentences: begin with a capital letter and end with a period.
Corrected in patch.
Thank you for explaining, I now realise this was in CONTRIBUTE.
>
>> --- a/doc/emacs/display.texi
>> +++ b/doc/emacs/display.texi
>> @@ -2215,7 +2215,8 @@ Display Custom
>> default), the multi-character key sequence echo shown according to
>> @code{echo-keystrokes} will include a short help text about keys which
>> will invoke @code{describe-prefix-bindings} (@pxref{Misc Help}) to show
>> -the list of commands for the prefix you already typed.
>> +the list of commands for the prefix you already typed. For a related
>> +help facility (@pxref{which-key}).
>
> The parentheses here don't look right. It is better to say
>
> For a related help facility, see @ref{which-key}.
>
>> +@node which-key
>
> It is better to use
>
> @anchor which-key
>
> Then you don't need the @subsection at all.
>
>> + @command{M-x which-key} is a global minor mode which helps in
>
> @command is for shell commands. Here you show something the user
> types, so the right markup is @kbd.
Corrected in patch.
Thanks, I have learnt more TeXinfo with this.
- bug#68929: [PATCH] Copy which-key from GNU ELPA into core, Jeremy Bryant, 2024/02/04
- bug#68929: [PATCH] Copy which-key from GNU ELPA into core, Justin Burkett, 2024/02/04
- bug#68929: [PATCH] Copy which-key from GNU ELPA into core, Eli Zaretskii, 2024/02/05
- bug#68929: [PATCH] Copy which-key from GNU ELPA into core, Justin Burkett, 2024/02/05
- bug#68929: [PATCH] Copy which-key from GNU ELPA into core, Jeremy Bryant, 2024/02/07
- bug#68929: [PATCH] Copy which-key from GNU ELPA into core, Eli Zaretskii, 2024/02/08
- bug#68929: [PATCH] Copy which-key from GNU ELPA into core, Jeremy Bryant, 2024/02/08
- bug#68929: [PATCH] Copy which-key from GNU ELPA into core, Jeremy Bryant, 2024/02/11
- bug#68929: [PATCH] Copy which-key from GNU ELPA into core, Eli Zaretskii, 2024/02/15
- bug#68929: [PATCH] Copy which-key from GNU ELPA into core,
Jeremy Bryant <=
- bug#68929: [PATCH] Copy which-key from GNU ELPA into core, Eli Zaretskii, 2024/02/17
bug#68929: [PATCH] Copy which-key from GNU ELPA into core, Jeremy Bryant, 2024/02/07
bug#68929: [PATCH] Copy which-key from GNU ELPA into core, Jeremy Bryant, 2024/02/08
bug#68929: [PATCH] Copy which-key from GNU ELPA into core, Eli Zaretskii, 2024/02/09
bug#68929: [PATCH] Copy which-key from GNU ELPA into core, Philip Kaludercic, 2024/02/07