[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#69056: 30.0.50; history-add-new-input and recursive minibuffers
From: |
Stefan Monnier |
Subject: |
bug#69056: 30.0.50; history-add-new-input and recursive minibuffers |
Date: |
Thu, 15 Feb 2024 14:20:08 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
>> Why not use `Vhistory_add_new_input`?
> Good question, I guess for some reason I assumed that `NILP (Vfoo)`
> doesn't check the buffer-local value like `find_symbol_value (Qfoo)`
> does...
The handling of Vfoo is quite delicate, but it does give you the value
in the current-buffer (i.e. they're changed as needed whenever we go
through `set_buffer`).
> Oh, that's much simpler indeed. And it seems to work just as well.
> Here's an updated patch (v2):
LGTM.
Eli&Stefan, any objection?
Stefan
- bug#69056: 30.0.50; history-add-new-input and recursive minibuffers, Eshel Yaron, 2024/02/11
- bug#69056: 30.0.50; history-add-new-input and recursive minibuffers, Stefan Monnier, 2024/02/15
- bug#69056: 30.0.50; history-add-new-input and recursive minibuffers, Eshel Yaron, 2024/02/15
- bug#69056: 30.0.50; history-add-new-input and recursive minibuffers, Stefan Monnier, 2024/02/15
- bug#69056: 30.0.50; history-add-new-input and recursive minibuffers, Eshel Yaron, 2024/02/15
- bug#69056: 30.0.50; history-add-new-input and recursive minibuffers,
Stefan Monnier <=
- bug#69056: 30.0.50; history-add-new-input and recursive minibuffers, Eli Zaretskii, 2024/02/15
- bug#69056: 30.0.50; history-add-new-input and recursive minibuffers, Stefan Monnier, 2024/02/15
- bug#69056: 30.0.50; history-add-new-input and recursive minibuffers, Eli Zaretskii, 2024/02/16
- bug#69056: 30.0.50; history-add-new-input and recursive minibuffers, Eli Zaretskii, 2024/02/15