bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#68958: [PATCH] Support bookmarking Xref results buffers


From: Dmitry Gutov
Subject: bug#68958: [PATCH] Support bookmarking Xref results buffers
Date: Sun, 11 Feb 2024 05:21:25 +0200
User-agent: Mozilla Thunderbird

On 07/02/2024 19:25, Juri Linkov wrote:
This patch adds support for bookmarking "*xref*" buffers and restoring
them later, even across Emacs sessions.

Shouldn't 'revert-buffer-function' in the xref buffer
be sufficient to reconstruct the buffer contents?

Usually modes set buffer-local 'revert-buffer-function'
to a lambda that reruns the top function with previous
arguments.  But it seems xref.el doesn't set it.

I can't find my original cause for not using this variable here, so if replacing the command xref-revert-buffer with setting revert-buffer-function makes things easier for someone, I'm all for it.

I once tried to use 'revert-buffer-function' to restore
xref buffers from the desktop, but abandoned the idea.
Not because xref.el doesn't set 'revert-buffer-function'.
But because it would take too much time to restore
the desktop while it will rerun all saved xref buffers.

OTOH, saving an xref bookmark makes more sense.
And probably your patch will help to implement
'revert-buffer-function' for xref as well.

I don't think bookmark would save the whole buffer contents. Would it? Otherwise, re-running the search(es) seems inevitable.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]