[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#67000: 30.0.50; [PATCH] Add support for reading/writing IELM input h
From: |
Stefan Kangas |
Subject: |
bug#67000: 30.0.50; [PATCH] Add support for reading/writing IELM input history |
Date: |
Sat, 10 Feb 2024 05:28:27 -0600 |
Simen Heggestøyl <simenheg@runbox.com> writes:
> Hi Stefan, thanks for your feedback. An updated patch is attached.
LGTM, please install. Feel free to handle the minor comments below as
you think is best, or disregard them.
Thanks!
>>> +(defcustom ielm-history-file-name
>>> + (locate-user-emacs-file "ielm-history.eld")
>>> + "If non-nil, name of the file to read/write IELM input history."
>>> + :type '(choice (const :tag "nil" nil)
>>
>> The tag here should be "Disable input history" or something like that.
>
> Ok. Should it be updated for `comint-input-ring-file-name' too then (I
> copied it from there)?
Yes, that could be improved too.
> From fe91c4f3aaefc109135c48ba26f8f21e87db465e Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= <simenheg@runbox.com>
> Date: Tue, 16 Jan 2024 08:21:41 +0100
> Subject: [PATCH] Add support for reading/writing IELM input history
>
> * lisp/ielm.el (inferior-emacs-lisp-mode): Add support for
> reading/writing input history.
How about:
"Add support for saving input history to a file"
> (ielm--history-file-name): Name of the file to read/write IELM input
> history.
Maybe:
"New variable indicating IELM input history file.
> +(defcustom ielm-history-file-name
> + (locate-user-emacs-file "ielm-history.eld")
> + "If non-nil, name of the file to read/write IELM input history."
> + :type '(choice (const :tag "Disable input history" nil)
> + file)
> + :version "30.1")
Maybe `file' should have a tag too?