bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#67246: 30.0.50; elixir-ts-mode uses faces inconsistently


From: Wilhelm Kirschbaum
Subject: bug#67246: 30.0.50; elixir-ts-mode uses faces inconsistently
Date: Mon, 5 Feb 2024 19:47:02 +0200
User-agent: Mozilla Thunderbird

On 2024/02/05 19:42, Dmitry Gutov wrote:

On 05/02/2024 19:34, Wilhelm Kirschbaum wrote:

Adding this as the first item to :feature 'elixir-definition fixes the function-call/name issue:

@@ -360,13 +360,19 @@ elixir-ts--indent-rules
  (defvar elixir-ts--font-lock-settings
    (treesit-font-lock-rules
     :language 'elixir
-   :feature 'elixir-function-name
+   :feature 'elixir-definition
     `((call target: (identifier) @target-identifier
+           (arguments
+            (call target: (identifier) @font-lock-function-name-face
+                  (arguments)))
+           (:match ,elixir-ts--definition-keywords-re @target-identifier))
+     (call target: (identifier) @target-identifier
             (arguments (identifier) @font-lock-function-name-face)

I will be working in Elixir this week and will set different fonts for to test it during the week, but don't think it should hold up installing the suggested patch so long.

Thanks!

Could you give an example of problematic highlighting, though? So I can keep it mind when installing both changes.
Of course, sorry:

def boo(:one), do: :boo

highlighted boo as function-call-face, not function-name-face. Same with


def foo("boo") do

end


and variants.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]