[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#68824: treesitter support for outline-minor-mode
From: |
Juri Linkov |
Subject: |
bug#68824: treesitter support for outline-minor-mode |
Date: |
Mon, 05 Feb 2024 09:22:08 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) |
>> Also a remaining question: why treesit-parent-until simply calls
>> ‘(funcall pred node)’ instead of supporting the standard format
>> that includes a regexp by using treesit-node-match-p?
>>
>> This causes such an inconvenience that for treesit-outline-level
>> that uses treesit-parent-until there is a need to wrap a regexp
>> in a lambda such as for html-ts-mode below.
>
> Nothing other than my oversight :-)
> I pushed a change to master that fixes this.
Thanks. It seems you forgot to replace 'funcall'
in 'treesit-parent-while' as well? ;-)
> As for the patch, I think treesit-outline-predicate could be set to
> a named function rather than a lambda generated on the fly, but
> I don’t have strong opinions about it (and maybe you have some reason
> to use a lambda?) Otherwise LGTM.
I completely agree, so will move lambdas to the named functions.
- bug#68824: treesitter support for outline-minor-mode, Juri Linkov, 2024/02/08
- bug#68824: treesitter support for outline-minor-mode, Eli Zaretskii, 2024/02/08
- bug#68824: treesitter support for outline-minor-mode, Juri Linkov, 2024/02/08
- bug#68824: treesitter support for outline-minor-mode, Eli Zaretskii, 2024/02/08
- bug#68824: treesitter support for outline-minor-mode, Juri Linkov, 2024/02/09
- bug#68824: treesitter support for outline-minor-mode, Eli Zaretskii, 2024/02/09
- bug#68824: treesitter support for outline-minor-mode, Juri Linkov, 2024/02/10
- bug#68824: treesitter support for outline-minor-mode, Eli Zaretskii, 2024/02/10
- bug#68824: treesitter support for outline-minor-mode, Juri Linkov, 2024/02/11