bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#68559: [PATCH] Improve Python shell completion


From: kobarity
Subject: bug#68559: [PATCH] Improve Python shell completion
Date: Thu, 01 Feb 2024 23:39:58 +0900
User-agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (Gojō) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)

Eli Zaretskii wrote:
> > Date: Mon, 29 Jan 2024 22:15:20 +0900
> > From: kobarity <kobarity@gmail.com>
> > Cc: Eli Zaretskii <eliz@gnu.org>,
> >     68559@debbugs.gnu.org
> > 
> > kobarity wrote:
> > > Liu Hui wrote:
> > > > Thanks for pointing it out. The attached patch should now restore
> > > > previous basic completion behavior in comments.
> > > 
> > > Thanks, I confirmed that basic completion (without keyword argument
> > > completion) can be performed within comments.
> > 
> > One additional comment regarding ERT.  pyenv installs an ipython shim
> > to the shims directory, if there is at least one virtualenv providing
> > ipython.  It can be found by `executable-find'.  However, it is not
> > usable unless the virtualenv is activated.  As a result, the
> > `python-shell-completion-at-point-ipython' ERT would fail unless a
> > virtualenv which provides ipython is activated.
> > 
> > This may be something pyenv users should take care of, but it is more
> > convenient for pyenv users like me to make the following changes.
> 
> Do we have a consensus about this issue?  Should I install the
> original patch, or are you still discussing it, and an updated patch
> will be posted soon?
> 
> Thanks.

Although I think there are a few things left unanswered, the latest
patch sent on Jan 26th is very worthwhile and stable enough to be
installed.  So, unless Liu is preparing a new patch, I agree that the
latest patch should be installed.  That way more people can try it and
find the problem, if any.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]