bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#67000: 30.0.50; [PATCH] Add support for reading/writing IELM input h


From: Simen Heggestøyl
Subject: bug#67000: 30.0.50; [PATCH] Add support for reading/writing IELM input history
Date: Fri, 19 Jan 2024 08:48:51 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

Stefan Kangas <stefankangas@gmail.com> writes:

> I'm not against adding a hook to `kill-emacs-hook', but it should be
> added when you start IELM and not on top-level.  We want to avoid any
> side effects from merely loading a file.

Fixed.

> I don't think this will work in its current form either: AFAICT,
> `comint-write-input-ring' saves it for the current buffer, and that's
> not guaranteed to be the *ielm* buffer when `kill-emacs-hook' runs.
>
> So you'd want to first switch to that buffer, I think.  It could also
> have been renamed meanwhile, so I think you want to save the actual
> buffer and not it's name (i.e. use `get-buffer').

Right, good catch. New attempt in the attached patch!

Attachment: 0001-Add-support-for-reading-writing-IELM-input-history.patch
Description: Text Data

-- Simen

reply via email to

[Prev in Thread] Current Thread [Next in Thread]