bug#62474: 29.0.60; wrong-type-argument from pcomplete-opt

[J.P.]

"J.P." <jp@neverwas.me> writes:

> Hi, this may be related to (or a duplicate of):
>
>   https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59750
>
> I first encountered it in ERC, but it appears to happen from any
> pcomplete/foo function that calls `pcomplete-opt' with a string of
> length two or more. AFAICT, this doesn't occur in Emacs 28.
>
> Example from emacs -Q:
>
>   1. M-x eshell
>   2. type "gzip -" and hit TAB
>   3. type "h" -> wrong-type-argument // "h" gets inserted anyway
>   4. type TAB -> wrong-type-argument

This appears to have been fixed by

  239db5d5162f6f9a4a6735e176c8d306f18e50e7
  Author:     Jim Porter <jporterbugs@gmail.com>
  AuthorDate: Tue Sep 5 18:27:21 2023 -0700
  Commit:     Jim Porter <jporterbugs@gmail.com>
  CommitDate: Tue Oct 10 13:00:38 2023 -0700
  
  Follows:    emacs-29.1 (168549)
  
  Revert commits dafa6d6badd6 and 72c45fa9109a
  
  These were there to work around deficiencies in how Eshell produces
  completions for 'pcomplete-argument' (Eshell passed various non-string
  objects to Pcomplete, which broke things).  Now, Eshell always returns
  a stringified form of the argument, with the original value stored via
  the text property 'pcomplete-arg-value'.
  
  * lisp/pcomplete.el (pcomplete-arg): Revert changes back to a simpler
  form.
  
  1 file changed, 7 insertions(+), 29 deletions(-)
  lisp/pcomplete.el | 36 +++++++-----------------------------

Closing.