bug#68428: 29.1.90; info-xref-tests fails

[Michael Albinus]

Michael Albinus <michael.albinus@gmx.de> writes:

Hi Eli,

>> No, it's a bug introduced by a recent commit, d58d0fa52.  I fixed it
>> now on the emacs-29 branch.
>
> Thanks! It passes now on emba (where I've detected it). But it still
> fails in my local environment. I will try to debug it.
>
>> (Not sure why you saw the problem back in 2021, the bad
>> cross-reference didn't exist then, AFAICT.)
>
> Don't know. Perhaps I shaould have cleaned up the git repo after every
> bisect step, instead calling simply 'make'. And perhaps it is related to
> the fact, that it still fails in my local environment.

Well, finally it is another bug. It is in function
info-xref-subfile-p. This function tries to determine, whether a given
file is an info subfile.

My emacs-29 branch is checked out in directory /home/albinus/src/emacs-29.
So there is, for example, a call of

(info-xref-subfile-p "/home/albinus/src/emacs-29/info/auth.info")

The function tries to decompose the filename via the regexp
"\\`\\(\\([^-]*-\\)*[^-]*\\)-[0-9]+\\(.*\\)\\'". This succeeds, and
returns

(match-string 1 filename) => "/home/albinus/src/emacs"
(match-string 3 filename) => "/info/auth.info"

This is wrong. string-match should return nil according to the
intention. And the call of

(file-exists-p "/home/albinus/src/emacs/info/auth.info")

succeeds also, because my Emacs master branch is located in
/home/albinus/src/emacs, and therefore
"/home/albinus/src/emacs/info/auth.info" does exist.

The appended patch fixes this. Shall I install it in the emacs-29 or the
master branch?

Best regards, Michael.

txte0RkLiO2vw.txt
Description: Text Data