bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals

[Jared Finder]

On 2024-01-09 04:40, Eli Zaretskii wrote:
> > Date: Mon, 08 Jan 2024 13:39:25 -0800
> > From:  Jared Finder via "Bug reports for GNU Emacs,
> >  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> >
> > I'd like tool-bar-make-keymap-1 to return a sensible keymap on
> > terminals.  This is only a small change from current code, patch
> > attached.
>
> I don't see any problems with the change, but please add comments
> there explaining that some parts of the code are supposed to work on
> frames where images cannot be displayed, because it is very easy to
> mistakenly assume this only needs to work on GUI frames.

New patch attached with comment added.

For the other discussions about making per-window tool bars part of 
core, I expect a handful of additional patches so I can file a separate 
bug report if that makes tracking things easier.

> Btw, what happens if display-images-p returns non-nil, but the session
> doesn't support images of the type used for tool-bar icons?

Then a keybind is generated with no image spec because find-image will 
not find any supported image.  Such binds are silently ignored by the 
current tool bar logic on PGTK and Mac builds.  You can see this 
behavior today in M-x customize, where the " Toggle hiding all values " 
bind is not displayed.  I was going to report this as a separate bug 
because this behavior seems poor -- I think a text only tool bar button 
would be preferred.

  -- MJF

0001-lisp-tool-bar.el-tool-bar-make-keymap-1-Populate-on-.patch
Description: Text Data