bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#67488: [PATCH] Fix typescript-ts-mode indentation for switch stateme


From: Dmitry Gutov
Subject: bug#67488: [PATCH] Fix typescript-ts-mode indentation for switch statements
Date: Tue, 28 Nov 2023 02:39:02 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0

On 27/11/2023 19:07, Noah Peart wrote:
Tags: patch

* lisp/progmodes/typescript-ts-mode.el(typescript-ts-mode): Add indentation
rule for switch case and default keywords.

Bug: `typescript-ts-mode` is missing indentation rules for 'case' and
'default' keywords in switch statements.

Recipe to reproduce:
Copy the following code into a buffer:

     const foo = (x: string) => {
       switch (x) {
                   case "a":
                   console.log(x);
                   return 1;
     case "b":
       return 2;
                   case "c":
                   default:
                     return 0;
       }
     };

And call the following function to configure typescript-ts-mode and
indent the buffer

     (defun my-ts-indentation ()
       (interactive)
       (setq indent-tabs-mode nil)
       (setq typescript-ts-mode-indent-offset 2)
       (typescript-ts-mode)
       (indent-region (point-min) (point-max)))

The indentation for the 'case' and 'default' branches within the switch
statement should still be unchanged due to missing indent rules.
Bug applies to emacs 29 as well.

Thanks! Can repro. The fix looks good as well.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]