[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#66187: read-file-name unexpected behavior when MUSTMATCH is a functi
From: |
Joseph Turner |
Subject: |
bug#66187: read-file-name unexpected behavior when MUSTMATCH is a function |
Date: |
Sat, 25 Nov 2023 22:49:48 -0800 |
Joseph Turner <joseph@breatheoutbreathe.in> writes:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>> Then I think we should install your patch on the emacs-29 branch,
>>> thanks.
>>
>> Thanks for the vote of confidence, but as Joseph points out, the patch
>> isn't actually doing what it says on the tin, so we first have to fix
>> it :-)
>
> Here's another potential solution. While the attached patch seems to
> work, I'm not sure that minibuffer-completion-confirm should be checked
> in completion--do-completion instead of completion--complete-and-exit.
>
> Thoughts?
I just ran the tests in /test/lisp/minibuffer-tests.el with this patch,
and they all still pass.
> Thanks!
>
> Joseph
>
> [2. text/x-diff;
> 0001-Fix-completing-read-functional-REQUIRE-MATCH-behavio.patch]...