[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed sta
From: |
Yuan Fu |
Subject: |
bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements |
Date: |
Fri, 24 Nov 2023 19:48:43 -0800 |
> On Nov 24, 2023, at 7:46 PM, Yuan Fu <casouri@gmail.com> wrote:
>
>
>
>> On Nov 20, 2023, at 10:13 AM, Noah Peart <noah.v.peart@gmail.com> wrote:
>>
>> Sorry, ignore the previous patch. A couple additional rules were needed to
>> handle
>> "while" and "else".
>>
>> On Mon, Nov 20, 2023 at 10:07 AM Noah Peart <noah.v.peart@gmail.com> wrote:
>> Here is an updated patch with the added "else_clause" and indentation test
>> for
>> statements without braces.
>>
>> On Mon, Nov 20, 2023 at 4:55 AM Noah Peart <noah.v.peart@gmail.com> wrote:
>> Yea, I'm using the same. But, would it be useful to have a way to set that
>> when
>> running tests without needing to temporarily add set
>> `treesit-extra-load-path` in
>> the test file?
>>
>> On Sun, Nov 19, 2023 at 5:38 AM Dmitry Gutov <dmitry@gutov.dev> wrote:
>> On 19/11/2023 08:08, Eli Zaretskii wrote:
>>>> Date: Sun, 19 Nov 2023 03:24:49 +0200
>>>> Cc:casouri@gmail.com,67031@debbugs.gnu.org
>>>> From: Dmitry Gutov<dmitry@gutov.dev>
>>>>
>>>> On 19/11/2023 02:12, Noah Peart wrote:
>>>>> Yea, I can do that.
>>>>>
>>>>> Is there a recipe for running the tests with a tree-sitter library path?
>>>> You mean with the default tree-sitter librayr path overridden? I'm not
>>>> sure.
>>> Why would an ERT test need that? We are supposed to test Emacs with
>>> the otherwise installed system features. As tree-sitter grammars are
>>> not part of Emacs, there should be no need to tell Emacs to use a
>>> grammar library other than the one installed on the system. Right?
>>
>> We have a way to override that with the variable
>> treesit-extra-load-path, so it follows that some users will take
>> advantage of it to add extra directories.
>>
>> I'm using ~/.emacs.d/tree-sitter/ myself.
>> <typescript-ts-mode-indentation.patch>
>
> That’s great! Is there anything else blocking us from applying this patch?
> Does Noah have the copyright assignment?
Never mind, just saw the follow-up. My email client’s threading has been messed
up and some messages ended up in different threads :-(
Yuan
- bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements, (continued)
- bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements, Noah Peart, 2023/11/20
- bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements, Noah Peart, 2023/11/20
- bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements, Dmitry Gutov, 2023/11/20
- bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements, Eli Zaretskii, 2023/11/20
- bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements, Noah Peart, 2023/11/20
- bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements, Eli Zaretskii, 2023/11/21
- bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements, Dmitry Gutov, 2023/11/21
- bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements, Eli Zaretskii, 2023/11/21
- bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements, Dmitry Gutov, 2023/11/21
- bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements, Yuan Fu, 2023/11/24
- bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements,
Yuan Fu <=
- bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements, Yuan Fu, 2023/11/18