bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#67062: 30.0.50; [PATCH] Abbreviate the revision in 'vc-annotate' (fo


From: Jim Porter
Subject: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in 'vc-annotate' (for Git)
Date: Sat, 11 Nov 2023 16:31:43 -0800

On 11/11/2023 2:00 PM, Dmitry Gutov wrote:
On 11/11/2023 09:41, Eli Zaretskii wrote:
If this is a Git-only issue, perhaps it would be better to have a
Git-only option, instead of defining a whole new VC method?

Our general approach is to prefer global options and dynamic dispatch on backends, resorting to using per-backend options when it's much easier to do.

In this case it might actually be more difficult to go the second route since the intention is to only use the short hash in this particular place. vc-annotate is common code and it will need to indicate that intention to the backend somehow.

Thanks for taking a look. It sounds like the strategy I went with is at least approximately right, so here's an updated patch with a NEWS entry.

I looked through the manuals and didn't see anywhere to add a mention of this though. There's a section about 'vc-annotate', but it's written for an Emacs user, rather than an Elisp programmer, and I think trying to explain "short revisions" in that section would just add unnecessary detail. If we still want to add some mention of this to a manual, I guess it would make the most sense in some section about how to use the VC package as an Elisp programmer. I didn't see much about that though...

Attachment: 0001-Abbreviate-the-VC-revision-in-vc-annotate-s-buffer-n.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]