bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#66806: 30.0.50; [PATCH] 'project-find-regexp' passes Git submodules


From: Eli Zaretskii
Subject: bug#66806: 30.0.50; [PATCH] 'project-find-regexp' passes Git submodules to the search program
Date: Sun, 29 Oct 2023 08:06:44 +0200

> Cc: dmitry@gutov.dev
> Date: Sat, 28 Oct 2023 22:36:07 -0700
> From: Jim Porter <jporterbugs@gmail.com>
> 
> --- a/lisp/progmodes/project.el
> +++ b/lisp/progmodes/project.el
> @@ -960,7 +960,8 @@ project-find-regexp
>           (default-directory (project-root pr))
>           (files
>            (if (not current-prefix-arg)
> -              (project-files pr)
> +              ;; XXX: See the comment in project-query-replace-regexp.
> +              (cl-delete-if-not #'file-regular-p (project-files pr))
                  ^^^^^^^^^^^^^^^^
I think we want to prefer using seq.el functions, since seq.el is
nowadays preloaded.  Is there a good reason to use cl-delete-if-not
here?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]