[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#66317: Project mode-line
From: |
sbaugh |
Subject: |
bug#66317: Project mode-line |
Date: |
Sun, 15 Oct 2023 22:42:52 +0000 (UTC) |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
An issue with this as installed in master: If I navigate to a file and
one of its ancestors is not readable by emacs, I'll get an error.
For example, when I visit /home/other/foo.txt, which is readable by me
even though /home/other is not, I get:
Error during redisplay: (eval (project-mode-line-format)) signaled
(permission-denied "Opening directory" "Permission denied"
"/home/other")
Here's one idea for a patch... but maybe we should be just flat-out
wrapping it in ignore-errors?
(BTW, I actually discovered this class of bug through
project-uniquify-dirname-transform, which is also affected by it, since
like project-mode-line, it runs project-current for basically every
buffer. So if we ignore-errors in project-mode-line-format, we also
need that in project-uniquify-dirname-transform. Maybe they should
share the lookup?)
diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index fd9c146a1fd..8bf1f4d0738 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -245,7 +245,8 @@ project-current
pr))
(defun project--find-in-directory (dir)
- (run-hook-with-args-until-success 'project-find-functions dir))
+ (ignore-error (permission-denied)
+ (run-hook-with-args-until-success 'project-find-functions dir)))
(defvar project--within-roots-fallback nil)
- bug#66317: Project mode-line, (continued)
- bug#66317: Project mode-line, Dmitry Gutov, 2023/10/09
- bug#66317: Project mode-line, Juri Linkov, 2023/10/10
- bug#66317: Project mode-line, Eshel Yaron, 2023/10/10
- bug#66317: Project mode-line, Eshel Yaron, 2023/10/10
- bug#66317: Project mode-line, Dmitry Gutov, 2023/10/10
- bug#66317: Project mode-line, Eshel Yaron, 2023/10/10
- bug#66317: Project mode-line, Dmitry Gutov, 2023/10/10
- bug#66317: Project mode-line, Ihor Radchenko, 2023/10/20
- bug#66317: Project mode-line, Dmitry Gutov, 2023/10/20
bug#66317: Project mode-line, Stefan Kangas, 2023/10/03
bug#66317: Project mode-line,
sbaugh <=
- bug#66317: Project mode-line, Dmitry Gutov, 2023/10/15
- bug#66317: Project mode-line, Juri Linkov, 2023/10/16
- bug#66317: Project mode-line, Eli Zaretskii, 2023/10/16
- bug#66317: Project mode-line, Juri Linkov, 2023/10/18
- bug#66317: Project mode-line, Dmitry Gutov, 2023/10/18
- bug#66317: Project mode-line, Juri Linkov, 2023/10/19
- bug#66317: Project mode-line, Dmitry Gutov, 2023/10/19
- bug#66317: Project mode-line, Juri Linkov, 2023/10/23
- bug#66317: Project mode-line, Dmitry Gutov, 2023/10/24
bug#66317: Project mode-line, Dmitry Gutov, 2023/10/18