|
From: | Herman |
Subject: | bug#66216: 28.2; scroll-up-line doesn't work if there is a before-string overlay with newline |
Date: | Sat, 30 Sep 2023 21:15:49 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 |
On 9/30/23 19:37, Eli Zaretskii wrote:
This is an example of magit's default blame presentation mode: http://www.mycpu.org/images/magit-blame.jpegThen line numbers will be incorrectWhy not? it depends on how the buffer text is generated, doesn't it?
The header in front of each code chunk is an overlay. If we wanted to implement this without overlays (just simple text lines with text properties), then the headers will receive a line number, making the original line number incorrect.
I suppose this is what you meant by "populating a scratch buffer with generated text"
How? The optimal solution is to edit the original buffer right away, just like how magit currently works. Maybe it's possible to sync between the scratch and the original buffer somehow. But this solution is awkward, and I'm sure it has a lot of pitfalls. Using overlays is a much more straightforward (from the package's viewpoint, and also from the user's).and also the buffer won't be editable.That is easily made possible from Lisp, isn't it?
A Lisp program written for Emacs definitely _should_ consider limitations and restrictions of the Emacs infrastructure it uses, if it wants to present a convenient, efficient, and well-looking interface to the users.
Fair enough. Are these limitations documented?Multiple-line overlays seem to work well in a lot of cases, several packages use it. It is just there are some cases where they don't work how one may expect. So one might think that such overlays are fully supported, and these cases are just bugs that can be fixed without too much work.
[Prev in Thread] | Current Thread | [Next in Thread] |