[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#66224: [PATCH] Add optional PREDICATE argument to read-directory-nam
From: |
Eli Zaretskii |
Subject: |
bug#66224: [PATCH] Add optional PREDICATE argument to read-directory-name |
Date: |
Fri, 29 Sep 2023 15:05:44 +0300 |
> Date: Tue, 26 Sep 2023 18:16:40 -0700
> From: Joseph Turner via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> This patch makes read-directory-name accept an optional PREDICATE arg
> so it can be used like read-file-name.
Any rationale?
> @@ -1719,7 +1719,9 @@ combining @var{directory} (or the current buffer's
> default directory
> if @var{directory} is @code{nil}) and @var{initial}. If both
> @var{default} and @var{initial} are @code{nil}, this function uses
> @var{directory} as substitute default, or the current buffer's default
> -directory if @var{directory} is @code{nil}.
> +directory if @var{directory} is @code{nil}. The union of sixth arg
> +@code{predicate} and @code{file-directory-p} is passed as the
This should be elaborated: what is meant by "the union of sixth arg
and 'file-directory-p'"?
> +@code{predicate} argument to ‘read-file-name’.
^^^^^^^^^^^^^^^^
That should be @code{read-file-name}
> +** 'read-directory-name' now accepts an optional PREDICATE argument.
> +The union of sixth arg PREDICATE and 'file-directory-p' is passed
> +as the PREDICATE argument to 'read-file-name'.
Likewise here, regarding the "union" part.
Also, since you submit the patch for the manual, this NEWS entry
should be marked with "+++".
> Fifth arg INITIAL specifies text to start with.
> DIR should be an absolute directory name. It defaults to
> -the value of `default-directory'."
> +the value of `default-directory'.
> +The union of sixth arg PREDICATE and `file-directory-p' is passed
> +as the PREDICATE argument to `read-file-name'."
The "union" part again.
Thanks.