[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#66113: Apply the entire diff buffer
From: |
Juri Linkov |
Subject: |
bug#66113: Apply the entire diff buffer |
Date: |
Wed, 27 Sep 2023 20:36:49 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) |
close 66113 30.0.50
thanks
>> ;; In git format-patch "^-- $" signifies
>> ;; the end of the patch.
>> (and (eq diff-buffer-type 'git)
>> (looking-at "^-- $"))
>> So I just copied this code here:
>
> That works. Thanks!
Actually this doesn't work for bzr that has a bug that adds
an extra line at the end. So I pushed a better fix.
> Ideally, I think point would move to the first failing hunk. But that's not
> urgent, could be a TODO for later.
There are many variants what would be better to do here.
Maybe also to show all failing hunks. And leaving point
at the beginning also makes sense, because then the user
could start applying hunks one by one with 'C-c C-a'
from the beginning until encountering the failing hunk
and handle it manually.
> Aside from that, I'm still not crazy about the binding. But that's not
> a technical issue.
Agreed, the key binding is the best among bad variants.
- bug#66113: Apply the entire diff buffer, (continued)
- bug#66113: Apply the entire diff buffer, Dmitry Gutov, 2023/09/21
- bug#66113: Apply the entire diff buffer, Juri Linkov, 2023/09/22
- bug#66113: Apply the entire diff buffer, Dmitry Gutov, 2023/09/22
- bug#66113: Apply the entire diff buffer, Juri Linkov, 2023/09/22
- bug#66113: Apply the entire diff buffer, Juri Linkov, 2023/09/23
- bug#66113: Apply the entire diff buffer, Dmitry Gutov, 2023/09/23
- bug#66113: Apply the entire diff buffer, Juri Linkov, 2023/09/24
- bug#66113: Apply the entire diff buffer, Dmitry Gutov, 2023/09/24
- bug#66113: Apply the entire diff buffer, Juri Linkov, 2023/09/25
- bug#66113: Apply the entire diff buffer, Dmitry Gutov, 2023/09/25
- bug#66113: Apply the entire diff buffer,
Juri Linkov <=