|
From: | Wilhelm Kirschbaum |
Subject: | bug#66183: elixir-ts-mode test failure |
Date: | Wed, 27 Sep 2023 09:17:51 +0200 |
User-agent: | mu4e 1.9.3; emacs 30.0.50 |
Yuan Fu <casouri@gmail.com> writes:
On Sep 26, 2023, at 1:26 PM, Wilhelm Kirschbaum <wkirschbaum@gmail.com> wrote:This seems to work if you set named on: treesit-node-prev-sibling,need to adjust it but the idea is there.With the new language-at-point definition, treesit-language-at canreturn the correct language, and the test passes again. Yuan [2. text/x-patch; example.diff]...otherwise it just tries to match the \"\"\" against H or F. (let* ((node (treesit-node-at point 'elixir))) (if (and (equal (treesit-node-type node) "quoted_content") (string-match-p (rx bos (or "H" "F") eos)- (treesit-node-text (treesit-node-prev-sibling node)))) + (treesit-node-text (treesit-node-prev-sibling node t))))'heex 'elixir)))I will spend some time in the next couple of hours to catch up to allthe changes.Ah, right. I’ll leave the specifics to you. As long as the language is derived from the node at point rather than parser range, it willbe fine. Also, there’s no rush.Hi Yuan,With the new changes I had to update some indentation rules as well. The following patch was tested against a couple of elixir files.There is another indentation issue with HEEx embeds, but think itsunrelated to this issue and will have a look this weekend.[2. text/x-patch; 0001-Fix-treesit-langauge-at-point-for-elixir-ts-mode.patch]...WilhelmThanks. I made some minor change and pushed to master. Yuan
Fantastic, thanks!
[Prev in Thread] | Current Thread | [Next in Thread] |