[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#66191: erc-ibuffer.el: suspicious use of hash-table-size
From: |
J.P. |
Subject: |
bug#66191: erc-ibuffer.el: suspicious use of hash-table-size |
Date: |
Mon, 25 Sep 2023 08:02:41 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Mattias EngdegÄrd <mattias.engdegard@gmail.com> writes:
> In erc-ibuffer.el:
>
> (define-ibuffer-column
> erc-members (:name "Users")
> (if (and (eq major-mode 'erc-mode)
> (boundp 'erc-channel-users)
> (hash-table-p erc-channel-users)
> (> (hash-table-size erc-channel-users) 0))
> (number-to-string (hash-table-size erc-channel-users))
> ""))
>
> Perhaps I'm mistaken but shouldn't hash-table-size be hash-table-count here?
Nice find! I've attached a patch that should fix the issue. If no one
says anything, I will add it or something similar in a few days. Thanks.
0001-5.6-Fix-wrong-User-column-count-in-erc-ibuffer.patch
Description: Text Data