[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65919: 29.1; build without xinput does not get focused when hovering
From: |
Amin Bandali |
Subject: |
bug#65919: 29.1; build without xinput does not get focused when hovering over window |
Date: |
Fri, 15 Sep 2023 01:02:33 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (gnu/linux) |
Po Lu writes:
> Amin Bandali <bandali@gnu.org> writes:
>
>> Hello,
>>
>> Po Lu writes:
>>
>>> This should be fixed on the master branch. [...]
>>
>> FYI your e1a730017d6 patch introduces the following compiler warning:
>>
>> process.c: In function ‘child_signal_notify’:
>> process.c:7436:54: warning: suggest braces around empty body in an ‘if’
>> statement [-Wempty-body]
>> 7436 | /* emacs_perror ("writing to child signal FD") */;
>> | ^
>
> Thanks. Does this silence the warning?
>
> diff --git a/configure.ac b/configure.ac
> index 7ca75be996d..3b5f3c1c37a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1776,6 +1776,9 @@ AC_DEFUN
> # Emacs doesn't need this paranoia.
> nw="$nw -Wbidi-chars=any,ucn"
>
> + # Or this hysteria, which impedes commentary within if statements.
> + nw="$nw -Wempty-body"
> +
> if test "$emacs_cv_clang" = yes; then
> nw="$nw -Wdouble-promotion"
> nm="$nm -Wunknown-pragmas"
>
Thanks, but it doesn't seem to. Also, IMHO this is a useful warning,
and the better fix would be to add the braces for that if statement.
That part of the code now looks quite fragile, and a problem waiting
to happen if that lone semicolon is accidentally mistakenly removed.
- bug#65919: 29.1; build without xinput does not get focused when hovering over window, Ivan Popovych, 2023/09/13
- bug#65919: 29.1; build without xinput does not get focused when hovering over window, Po Lu, 2023/09/13
- bug#65919: 29.1; build without xinput does not get focused when hovering over window, Ivan Popovych, 2023/09/14
- bug#65919: 29.1; build without xinput does not get focused when hovering over window, Po Lu, 2023/09/14
- bug#65919: 29.1; build without xinput does not get focused when hovering over window, Ivan Popovych, 2023/09/14
- bug#65919: 29.1; build without xinput does not get focused when hovering over window, Po Lu, 2023/09/14
- bug#65919: 29.1; build without xinput does not get focused when hovering over window, Po Lu, 2023/09/14
- bug#65919: 29.1; build without xinput does not get focused when hovering over window, Amin Bandali, 2023/09/14
- bug#65919: 29.1; build without xinput does not get focused when hovering over window, Po Lu, 2023/09/15
- bug#65919: 29.1; build without xinput does not get focused when hovering over window,
Amin Bandali <=
- bug#65919: 29.1; build without xinput does not get focused when hovering over window, Stefan Kangas, 2023/09/15
- bug#65919: 29.1; build without xinput does not get focused when hovering over window, Po Lu, 2023/09/15
- bug#65919: 29.1; build without xinput does not get focused when hovering over window, Stefan Kangas, 2023/09/15
- bug#65919: 29.1; build without xinput does not get focused when hovering over window, Eli Zaretskii, 2023/09/15
- bug#65919: 29.1; build without xinput does not get focused when hovering over window, Bob Rogers, 2023/09/15
- bug#65919: 29.1; build without xinput does not get focused when hovering over window, Po Lu, 2023/09/15
- bug#65919: 29.1; build without xinput does not get focused when hovering over window, Ivan Popovych, 2023/09/15
- bug#65919: 29.1; build without xinput does not get focused when hovering over window, Po Lu, 2023/09/15