[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59458: [PATCH] Fix tracing for advanced scoring
From: |
Stefan Kangas |
Subject: |
bug#59458: [PATCH] Fix tracing for advanced scoring |
Date: |
Mon, 11 Sep 2023 17:32:20 -0700 |
Version: 30.1
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> On 09/07/23 14:07 PM, Stefan Kangas wrote:
>
>> Eric,
>>
>> It would be great if you could help review this. Thanks in advance.
>
> I've taken a closer look, and I do think this is okay. The `when' after
> the `dolist' only fires if the rule matches, the `if' is only there to
> see if this article has been previously scored or not. So moving the
> "(when trace" up to the top-level of the containing `when' (ie, out of the
> `if') does look like the right thing to do.
Thanks. Installed it on master as commit e25ad6e2a30.