[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65704: 29.1; Most code of `project-ignores' seems to be dead code
From: |
Damien Cassou |
Subject: |
bug#65704: 29.1; Most code of `project-ignores' seems to be dead code |
Date: |
Wed, 06 Sep 2023 21:12:59 +0200 |
Dmitry Gutov <dmitry@gutov.dev> writes:
> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
> index 29a81c7e151..2eea0ef72e0 100644
> --- a/lisp/progmodes/project.el
> +++ b/lisp/progmodes/project.el
> @@ -566,6 +566,12 @@ project-try-vc
> (project--submodule-p root))
> (let* ((parent (file-name-directory (directory-file-name
> root))))
> (setq root (vc-call-backend 'Git 'root parent))))
> + (when (not backend)
it seems that `root' is sometimes nil at this point so I would change
this line to
(when (and (not backend) root)
I've used this for the day and it seems to work fine.
--
Damien Cassou
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
- bug#65704: 29.1; Most code of `project-ignores' seems to be dead code, Damien Cassou, 2023/09/02
- bug#65704: [PATCH] project.el: Fix bug in project-ignores, Damien Cassou, 2023/09/02
- bug#65704: 29.1; Most code of `project-ignores' seems to be dead code, Dmitry Gutov, 2023/09/02
- bug#65704: 29.1; Most code of `project-ignores' seems to be dead code, Damien Cassou, 2023/09/04
- bug#65704: 29.1; Most code of `project-ignores' seems to be dead code, Dmitry Gutov, 2023/09/04
- bug#65704: 29.1; Most code of `project-ignores' seems to be dead code, Damien Cassou, 2023/09/04
- bug#65704: 29.1; Most code of `project-ignores' seems to be dead code, Dmitry Gutov, 2023/09/04
- bug#65704: 29.1; Most code of `project-ignores' seems to be dead code, Damien Cassou, 2023/09/05
- bug#65704: 29.1; Most code of `project-ignores' seems to be dead code, Dmitry Gutov, 2023/09/05
- bug#65704: 29.1; Most code of `project-ignores' seems to be dead code, Damien Cassou, 2023/09/05
- bug#65704: 29.1; Most code of `project-ignores' seems to be dead code,
Damien Cassou <=
- bug#65704: 29.1; Most code of `project-ignores' seems to be dead code, Dmitry Gutov, 2023/09/06
bug#65704: 29.1; Most code of `project-ignores' seems to be dead code, Dmitry Gutov, 2023/09/04