[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29
From: |
João Távora |
Subject: |
bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29 |
Date: |
Tue, 5 Sep 2023 01:07:50 +0100 |
On Sat, Sep 2, 2023 at 8:14 PM Stefan Kangas <stefankangas@gmail.com> wrote:
>
> João Távora <joaotavora@gmail.com> writes:
>
> > Can you make a list of the safest/most important ones? (keeping on mind
> > things like backward-compatibility, etc...).
>
> I don't have the bandwidth for a detailed list right now.
>
> This was an easy one I spotted:
>
> https://github.com/joaotavora/yasnippet/pull/1125
Thanks, I merged that one and it indeed fixes the all test failures
on Emacs28.
I still have two new test failures on latest Emacs and I suspect
it's something to do with overlay changes.
Stefan Monnier can you have a look maybe? Could be related to your
overlay changes?
With Emacs 28 this passes:
emacs -Q --batch -L . -l yasnippet-tests.el --eval
'(ert-run-tests-batch-and-exit "issue-824")'
With latest master it doesn't. The issue seems to be a call to
yas-active-snippets which calls overlays-in in where BEG and END
are 1 and which returns no overlays because they have mysteriously
evaporated. But there are no overlays with 'evaporate' properties
that I can detect.
João
- bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29, Stefan Kangas, 2023/09/01
- bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29, Stefan Monnier, 2023/09/01
- bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29, João Távora, 2023/09/01
- bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29, Stefan Monnier, 2023/09/01
- bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29, Stefan Kangas, 2023/09/01
- bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29, João Távora, 2023/09/02
- bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29, Stefan Kangas, 2023/09/02
- bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29, Stefan Monnier, 2023/09/02
- bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29,
João Távora <=
- bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29, Stefan Monnier, 2023/09/04
- bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29, João Távora, 2023/09/04
- bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29, Stefan Monnier, 2023/09/04