bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#63627: Improve plstore.el and fix various issues of it


From: Jens Schmidt
Subject: bug#63627: Improve plstore.el and fix various issues of it
Date: Mon, 4 Sep 2023 00:22:52 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0

On 2023-09-02  09:41, Eli Zaretskii wrote:

> Date: Thu, 31 Aug 2023 12:21:38 +0200
> Cc: 63627@debbugs.gnu.org
> From: Jens Schmidt <jschmidt4gnu@vodafonemail.de>

> OK, so I've now installed the documentation changes on emacs-29.
Thanks.

> Please prepare the other patch for master, and let's install it there.

Done, please see attached patch.

>> Actually, it *would* be interesting to know what you check in such a
>> situation, if it could be easily described.
> 
> I look at the commit log message, make sure the relevant tests still
> pass, and do anything else my eyes suggest while looking at the patch.

Ok.

Please let your eyes rest in particular on lines 310 and following of
test/lisp/plstore-tests.el, where I have tried to detect and avoid
hangs related to GnuPG 2.4.*.

I have executed the new tests on GNU/Linux only, since that is the only
platform I have available.  Should I take extra steps to get these tests
executed on other platforms than GNU/Linux *before* you commit them?  If
yes, which steps?

The rest of the tests should be more or less standard.  Except
probably for the fact that there is still much infrastructure and few
actual tests, but I plan to change that.

Thanks.

Attachment: 0001-Add-tests-for-plstore.el.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]